Fix cidata user-data ca_certs yaml content #2266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
reviewed
Apr 4, 2024
Member
Author
|
The initial attempt got a bit confusing, since it was trying to validate the config from the test cases... The actual user-data in the default template looked like: ca_certs:
remove_defaults: false
trusted: nullBetter to fail validation, if the boolean pointer is still |
This is failing the cloud-config jsonschema validation, later.
$ sudo cloud-init schema --system
Error: Cloud config schema errors:
ca_certs.trusted: None is not of type 'array'
Signed-off-by: Anders F Björklund <[email protected]>
Signed-off-by: Anders F Björklund <[email protected]>
afbjorklund
force-pushed
the
cidata-cacerts
branch
from
14808db to
eea8427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is failing the cloud-config jsonschema validation, later.
user-datais failing cloud-config schema validation #2265There are some additional fixes, to be followed up in another PR:
stringtype is deprecated. Use anintegerinstead.These are either version-dependent (on the runtime cloud-init version, which we don't know just yet)
Or depends on the implementation, where the canonical python implementation does a magic
replace.